Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab extension dropdown having dead non-clickable hover area #28908

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix tab extension dropdown having dead non-clickable hover area #28908

merged 2 commits into from
Jul 18, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 18, 2024

Closes #28899.

@smoogipoo
Copy link
Contributor

This isn't entirely correct:
image

Perhaps keep paddings but move the hover internal to the SpriteIcon?

@peppy
Copy link
Member Author

peppy commented Jul 18, 2024

Just gonna keep things simple and remove the margin/padding. It doesn't look too bad.

@smoogipoo
Copy link
Contributor

smoogipoo commented Jul 18, 2024 •
edited
Loading

That was going to be my initial suggestion anyway...

@smoogipoo smoogipoo merged commit 868604c into ppy:master Jul 18, 2024
9 of 11 checks passed
@peppy peppy deleted the fix-dead-padding branch July 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
size/XS type:behavioural
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ellipsis button in beatmap "Sort by" has clickable margin that does nothing.
2 participants
@peppy @smoogipoo